Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FreeBSD PR CI does not checkout the correct pr branch #1960

Closed
tiehuis opened this issue Feb 14, 2019 · 4 comments
Closed

FreeBSD PR CI does not checkout the correct pr branch #1960

tiehuis opened this issue Feb 14, 2019 · 4 comments
Labels
upstream An issue with a third party project that Zig uses.
Milestone
0.4.0

Comments

@tiehuis
Copy link
Member

tiehuis commented Feb 14, 2019

The FreeBSD CI script does not appear to checkout the pr when being invoked by the github pr webhook. It instead pulls the current master and tests that instead.

For example, take this recent pr: #1958

The compiler version is reported as being 0.3.0+2911eb34. However the pr latest commit is de7c551.
@andrewrk andrewrk added the upstream An issue with a third party project that Zig uses. label Feb 14, 2019
@andrewrk andrewrk added this to the 0.4.0 milestone Feb 14, 2019
@andrewrk
Copy link
Member

This sounds like a sr.ht bug which we'll have to report.

@andrewrk
Copy link
Member

Reported upstream: https://todo.sr.ht/~sircmpwn/dispatch.sr.ht/24

@andrewrk
Copy link
Member

I pushed a4e32d9 which follows Drew's suggestion. Next pull request that is open we will find out if it fixed it.

@andrewrk
Copy link
Member

Based on #1961, appears to be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
upstream An issue with a third party project that Zig uses.
Projects
None yet
Milestone
0.4.0
Development

No branches or pull requests
2 participants
@andrewrk @tiehuis