Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

@asyncCall and @newStackCall should accept the call arguments as a tuple #4621

Closed
alexnask opened this issue Mar 4, 2020 · 4 comments · Fixed by #5696
Closed

@asyncCall and @newStackCall should accept the call arguments as a tuple #4621

alexnask opened this issue Mar 4, 2020 · 4 comments · Fixed by #5696
Labels
accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone
0.7.0

Comments

@alexnask
Copy link
Contributor

alexnask commented Mar 4, 2020 •
edited

Currently they accept a variable number of arguments instead.
@alexnask alexnask changed the title @asyncCall should accept the call arguments as a tuple @asyncCall and @newStackCall should accept the call arguments as a tuple Mar 4, 2020
@mproved
Copy link
Contributor

mproved commented Mar 4, 2020

@newStackCall got removed in 71b7f4b

@alexnask
Copy link
Contributor Author

alexnask commented Mar 4, 2020

@syscall0
The code is still in the compiler which is why I included it.

@mproved
Copy link
Contributor

mproved commented Mar 4, 2020

Mmm, I wonder why only documentation was removed but not the actual code

@andrewrk
Copy link
Member

andrewrk commented Mar 5, 2020

It's a low-priority experimental feature which is currently broken in practice on most architectures, but could work in theory.

Whether it makes it into the lang spec or not will be decided before 1.0

@andrewrk andrewrk added the proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. label Mar 7, 2020
@andrewrk andrewrk added this to the 0.7.0 milestone Mar 7, 2020
@alexnask alexnask mentioned this issue Jun 24, 2020
Merged
@andrewrk andrewrk added the accepted This proposal is planned. label Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted This proposal is planned. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

@asyncCall now takes arguments as a tuple instead of varargs alexnask/zig
3 participants
@andrewrk @alexnask @mproved