Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code golf reveals shocking discovery: .* and ** don't require a space! #6823

Closed
ikskuh opened this issue Oct 26, 2020 · 0 comments · Fixed by #6858
Closed

Code golf reveals shocking discovery: .* and ** don't require a space! #6823

ikskuh opened this issue Oct 26, 2020 · 0 comments · Fixed by #6858
Labels
accepted This proposal is planned. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Milestone
0.7.0

Comments

@ikskuh
Copy link
Contributor

ikskuh commented Oct 26, 2020 

var sequence = "repeat".*** 10;

I don't think we should allow this and require a space character between .* and **.

var sequence = "repeat".* ** 10;
@Vexu Vexu added the proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. label Oct 26, 2020
@Vexu Vexu added this to the 0.8.0 milestone Oct 26, 2020
@andrewrk andrewrk added accepted This proposal is planned. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. labels Oct 26, 2020
@travv0 travv0 mentioned this issue Oct 28, 2020
Merged
@Vexu Vexu modified the milestones: 0.8.0, 0.7.0 Oct 30, 2020
@ifreund ifreund mentioned this issue Mar 28, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
accepted This proposal is planned. breaking Implementing this issue could cause existing code to no longer compile or have different behavior. contributor friendly This issue is limited in scope and/or knowledge of Zig internals. proposal This issue suggests modifications. If it also has the "accepted" label then it is planned.
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

don't allow a token starting with an asterisk directly following .* travv0/zig
3 participants
@andrewrk @ikskuh @Vexu