New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tail call codegen for error returns #690

Open
andrewrk opened this Issue Jan 15, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@andrewrk
Member

andrewrk commented Jan 15, 2018

for error unions it looks like this:

  tail call fastcc void @__zig_return_error(%StackTrace* %0, i8* blockaddress(@foo, %ReturnError)), !dbg !50
  ret i16 %6, !dbg !50

We could have __zig_return_error take the sret parameter and populate the error value, then return void, so that it can be a tail call.

for pure errors we can pass the error code and return it, and then return it in the parent, another tail call.

Then look at the generated assembly and make sure we're doing tail calls. This is to keep the size of the code generated small for error return tracing. What is a return statement in code without error return tracing can become a jump instruction in code with error return tracing.

@andrewrk andrewrk added this to the 0.3.0 milestone Jan 15, 2018

@andrewrk andrewrk modified the milestones: 0.3.0, 0.4.0 Feb 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment