New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json Stringify option to not write out null optional fields #8979
Conversation
Found another failure case. Needs more testing. |
I wonder if a better option might be a |
I'm unconvinced. It does make sense but is there a use-case where you don't want to stringify nulls that go OTW but would want to stringify some local default that doesn't make sense as a default on the other end? i.e.
Of course, the problem here is easily avoided, however, not convinced that it's a good user experience. |
This appears to be working properly now! |
if (child_options.whitespace) |child_whitespace| { | ||
try out_stream.writeByte('\n'); | ||
try child_whitespace.outputIndent(out_stream); | ||
var emit_field = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks redundant with field_output
Fixed version of #8908 with added test to parse stringify output