Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to disable std.Progress.dont_print_on_dumb #9633

Closed
nektro opened this issue Aug 27, 2021 · 3 comments · Fixed by #20059
Closed

option to disable std.Progress.dont_print_on_dumb #9633

nektro opened this issue Aug 27, 2021 · 3 comments · Fixed by #20059
Labels
proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. standard library This issue involves writing Zig code for the standard library.
Milestone

Comments

@nektro
Copy link
Contributor

nektro commented Aug 27, 2021

TERM=dumb or otherwise that does not support the cursor moving ansi escape codes should still print, but have the items each print on their own line.

If the user decides they do not want the output to print they would still be free to do zig build > /dev/null.

@andrewrk andrewrk added proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. standard library This issue involves writing Zig code for the standard library. labels Aug 27, 2021
@andrewrk andrewrk added this to the 0.10.0 milestone Aug 27, 2021
@andrewrk
Copy link
Member

cc @g-w1 (author of the feature)

@g-w1
Copy link
Contributor

g-w1 commented Aug 29, 2021

This is a useful feature. Lets say I want to see which tests ran, as a kind of a sanity check, I would do ❯ ./zig build test-stage2 -Dskip-compile-errors 2>&1 |less I get this
image
, but when I remove dont_print_on_dumb, the compilation progress shows, which is very annoying. Then you have to scroll down to see the actual useful information.
image

Compilation progress is only useful while compilation is going, not after. Which tests ran is useful after also.

Is this feature causing a problem for you? If not, I think we should keep it, as it improves the ui for me.

@nektro
Copy link
Contributor Author

nektro commented Aug 29, 2021

Yes, not seeing the compilation progress means im totally in the dark when using some CIs when zig build is running.

@nektro nektro changed the title remove std.Progress.dont_print_on_dumb option to disable std.Progress.dont_print_on_dumb Feb 23, 2022
@andrewrk andrewrk modified the milestones: 0.16.0, 0.14.0 May 25, 2024
@andrewrk andrewrk mentioned this issue May 25, 2024
4 tasks
@andrewrk andrewrk modified the milestones: 0.14.0, 0.13.0 May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
proposal This issue suggests modifications. If it also has the "accepted" label then it is planned. standard library This issue involves writing Zig code for the standard library.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants