SPARCv9: make more tests pass #9853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the wrong branch target and register check. (ziglang#9801)
koachan
force-pushed
the
sparc64-unittests
branch
from
3d2854a
to
d7a5b12
Compare
koachan
commented
Oct 10, 2021
| pub const RCVTIMEO_NEW = 66; | ||
| pub const SNDTIMEO_NEW = 67; | ||
| pub const DETACH_REUSEPORT_BPF = 68; | ||
| } else if (is_sparc) struct { |
There was a problem hiding this comment.
Need some codestyle suggestions for this part, since SPARC has an entirely different set of constants for those.
Should I split it into a different file?
There was a problem hiding this comment.
Up to you, whatever you think is better. Thanks for the patch!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #9801 and most of the socket-related tests.