std.fs.Dir.makeOpenPath: optimize path already existing #13828
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matu3ba
force-pushed
the
optimize_makeOpenPath
branch
3 times, most recently
from
7b6da7c
to
674f130
Compare
Uses a single NtCreateFile syscall on windows. Closes ziglang#12474. Thanks to @joedavis for the PR.
matu3ba
force-pushed
the
optimize_makeOpenPath
branch
from
674f130
to
dfe58cf
Compare
|
Stale draft with failing tests. |
|
True, I'll have a look this weekend. Got busy with other stuff. Must wait another week or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a single NtCreateFile syscall on windows.
Closes #12474. Thanks to @joedavis for the PR.