langref: clarify functionality of the round builtin #19503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torque
force-pushed
the
round-builtin-langref
branch
2 times, most recently
from
0f53a1c
to
c2f6626
Compare
castholm
reviewed
Apr 1, 2024
torque
force-pushed
the
round-builtin-langref
branch
from
c2f6626
to
79132eb
Compare
|
Please also update the identical comment for the std.math.round() function! |
|
thanks for the note, will do when I get a chance. |
A test has also been added to demonstrate the expected behavior.
torque
force-pushed
the
round-builtin-langref
branch
from
79132eb
to
d4d75ba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Questions regarding the behavior of this have shown up in the IRC channel more than once, and I think the current wording is misleading. I also added a test, which I think demonstrates the described behavior fairly unambiguously.