std: hash_map: Better handling of no available slots case #7472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever self.available reaches zero we're not allowed to use free slots, enforce this constraint while looking for a usable one. Closes ziglang#7468
|
So... what the fuck is wrong with the Windows CI? Both this and #7447 are failing due to some OOM error that I don't see on master... |
Keep scanning the whole set of slots and exit when we've reached the starting index. At that point if we don't have a free (!isUsed) slot it means we've overshot the maximum capacity. Closes ziglang#7494
|
Yes, in #7494 I was wondering if this was just be a documentation problem. |
Vexu
added
the
standard library
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever self.available reaches zero we're not allowed to use free
slots, enforce this constraint while looking for a usable one.
Closes #7468
We need a test case that's independent of the hash function being used, I'll see if I can come up with something nice later.