Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

langref- fix packed struct error code #9480

Merged
merged 2 commits into from Aug 1, 2021
Merged

langref- fix packed struct error code #9480

merged 2 commits into from Aug 1, 2021

Conversation

nektro
Copy link
Contributor

@nektro nektro commented Jul 29, 2021

The current docs say the error for this section is docgen_tmp/test.zig:8:11: error: unused local constant. However, they also mention that it should be failing due to #1994 instead. This change uses the variable so that the proper error can propagate.

Copy link
Member

@Vexu Vexu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add the expected error message using the test_err|expected type... syntax to both of your prs so that they don't regress again.

There also seem to be a few other places that are missing the error if you want to fix those too.

@Vexu Vexu merged commit 7e52a09 into ziglang:master Aug 1, 2021
@nektro nektro deleted the patch-2 branch August 1, 2021 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants