Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deflate.zig: fix bits_left overflow at EndOfStream and @intCast truncation with empty Huffman table #9848

Closed
wants to merge 3 commits into from
Closed

deflate.zig: fix bits_left overflow at EndOfStream and @intCast truncation with empty Huffman table #9848

wants to merge 3 commits into from

Conversation

mattbork
Copy link
Contributor

Fixes #9842.

ifreund
ifreund requested changes Sep 27, 2021
View reviewed changes
lib/std/compress/deflate.zig Outdated Show resolved Hide resolved
@mattbork mattbork closed this Sep 27, 2021
@mattbork
Copy link
Contributor Author

Sorry, there's actually still a problem separate from empty Huffman tables that is causing integer overflows on the fuzzed test cases. I think the problem may be in using Huffman table that puff.c would reject as incomplete, but I have to look at this more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ifreund ifreund ifreund requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deflate.InflateStream bits_left unsafety
2 participants
@mattbork @ifreund