Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency between Type and ElementType #22

Closed
silversquirl opened this issue May 31, 2021 · 0 comments · Fixed by #107
Closed

Inconsistency between Type and ElementType #22

silversquirl opened this issue May 31, 2021 · 0 comments · Fixed by #107

Comments

@silversquirl
Copy link
Contributor

In Type, the OpenGL names are used for types, eg. unsigned_byte etc.
In ElementType, the Zig names are used for the same types, eg. u8 etc.

One set of names should be chosen and used consistently throughout zgl.
Nairou added a commit to Nairou/zgl that referenced this issue May 5, 2024
@Nairou
Rename ElementType fields for consistency
2909e55 
Fixes ziglibs#22, which has a point. Both `Type` and `ElementType` have
fields resembling primitive types, but they are actually named
identifiers, matching labels in the OpenGL documentation.
@Nairou Nairou mentioned this issue May 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename ElementType fields for consistency Nairou/zgl
1 participant
@silversquirl