Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recalculate bad FCS for protocol versions 8 or newer #510

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

Adminiuga
Copy link
Collaborator

Recalculate FCS for EZSP version 8, 9 or newer when capturing ZigBee traffic.

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (592d758) compared to base (e74aa85).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #510   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         3302      3302           
=========================================
  Hits          3302      3302           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@puddly puddly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I can confirm this bug is still present with an EZSP 9 coordinator...

@puddly puddly merged commit 8d9f185 into zigpy:dev Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants