Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize context managers in send_packet #511

Merged
merged 1 commit into from
Nov 13, 2022

Conversation

dmulcahey
Copy link
Contributor

@dmulcahey dmulcahey commented Nov 13, 2022

This PR reorganizes the context managers in send_packet so that we don't stack up a bunch of TSN's that we can't use. Now we won't create a request / reserve a TSN until we are unblocked by the concurrency managing semaphore.

This should correct floods of duplicate TSN messages during restarts for large networks.

@codecov-commenter
Copy link

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (8032068) compared to base (8d9f185).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff            @@
##               dev      #511   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           47        47           
  Lines         3302      3302           
=========================================
  Hits          3302      3302           
Impacted Files Coverage Δ
bellows/zigbee/application.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@puddly puddly merged commit 6150cbb into zigpy:dev Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants