New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Tuya/MEOS Thermostat - the time gets unsynchronized making built-in schedules unusable. #831
Comments
Tuya should have just sticked to the standards. Nominally nthe device is a zigbee device, but really is using a proprietary protocol. |
Yeah, I understand this is a nasty thing, but.... are we going to do something with it? Edit no 1. Scenario: . Isn't it strange? Edit no 2. Edit no 3. Any other tests I could do? |
@sstefanowski What thermostat model do you have? I have a _TZE200_aoclfnxz thermostat and I'm having the same problem. I'm not sure, but I believe that the command to set the time from ZHA to the device is already in the code, but it's only applied to some thermostatic valves and not to all tuya thermostats. |
I was looking at the code and I think I've fixed it for my device. I've just added this line of code: So now the code looks like this:
I waited a few minutes until the thermostat asked for a time sync to the server: After that, I checked the thermostat and the time was correct. I'll keep an eye on it for the next few days to see if the problem was solved. |
BTW. My Thermostat is heater valve _TZE200_ywdxldoj OK. I can see the code and it looks like this handler should work but it is not working... I enabled debug in configuration.yaml yesterday and... NOT a single log entry with but...
and Can these Isn't it something wrong with
the comment in the code suggests that the size of the payload of
while
Any hints how to fix it? |
Update 1:
to
and now... Question to @Adminiuga and @xonestonex who is the main contributor to the ZHA quirk for Moes Thermostatic valve. Update 2:
So I changed it to I used I don't know if this is a fully correct fix. but having this is FAR more accurate than having a BUG and unsynchronized time. I have no code branched. Can any developer implement this change and create a pull request for this, so we could have this in next release? |
I too have the |
I can confirm that changing line 135 to |
I just received a new HY368 and its name is |
I was adding it in #820 if the user putting all info OK it shall working out of the box. |
Hi @MattWestb, |
Hi @MattWestb, Thanks for an update but... I can see you committed: Changing it to Also, I don't meaning of these bytes but the previous entry using TuyaTimePayload for set_time_request was a real bug. BTW. Maybe I should comment on a pull request directly what do you think? |
OK, I'll comment on Pull Request |
Updated PR |
@MattWestb, |
Download the commit as zip file or copy only the file changed and putting it in your system so we can see its working. |
* Fix for MEOS TRV Time setting From #831 (comment) User have reported that its working changing the time request and the TRV is getting the right time then its pulling the coordinator for it. I dont know if its doing more bad things but for the moment its only the MOES TRV that is using the time setting (i think its made different for other models but is for the moment not used / implanted in other then the MOES TRV). * Update __init__.py Updating with ("set_time_request", (t.data16,), True),
* Fix for MEOS TRV Time setting From zigpy#831 (comment) User have reported that its working changing the time request and the TRV is getting the right time then its pulling the coordinator for it. I dont know if its doing more bad things but for the moment its only the MOES TRV that is using the time setting (i think its made different for other models but is for the moment not used / implanted in other then the MOES TRV). * Update __init__.py Updating with ("set_time_request", (t.data16,), True),
This is in release 0,57 so we can close the issue... |
The problem:
The Tuya/MEOS Thermostat support built-in heating schedules (and change temperature up to 6 times a day).
Unfortunately, the clock inside the device is not very precise and the time gets unsynchronized after a few days.
ZHA should take care of the device time and re-synchronize it with some default frequency (e.g. once a day).
The device should always receive a local date/time from ZHA. This also should be taken into consideration when summer/winter time changes
Similar Zigbee solutions take care of the device clock e.g. Tuya platform and Zigbee2MQT.
The solutions for the same issue in Zigbee2MQTT:
Koenkk/zigbee2mqtt#5916
Koenkk/zigbee2mqtt#5620
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
When checking the time on the device it should be always correct. ZHA should take care of date/time settings and re-synchronize them periodically as the other Zigee platforms do.
The device should always receive a local date/time from ZHA. This also should be taken into consideration when summer/winter time changes
Screenshots
N/A
Additional context
N/A
The text was updated successfully, but these errors were encountered: