Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ts011f_plug.py #1107

Merged
merged 5 commits into from Oct 28, 2021
Merged

Update ts011f_plug.py #1107

merged 5 commits into from Oct 28, 2021

Conversation

miit86
Copy link
Contributor

@miit86 miit86 commented Oct 28, 2021 •
edited

Changed Cluster Attributes

AC_CURRENT_MULTIPLIER = 0x0602
 AC_CURRENT_DIVISOR = 0x0603

@miit86
Update ts011f_plug.py
9a0b11c 
Changed Cluster Attributes
```    
AC_VOLTAGE_MULTIPLIER = 0x0602
 AC_VOLTAGE_DIVISOR = 0x0603
```
@codecov-commenter
Copy link

codecov-commenter commented Oct 28, 2021 •
edited

Codecov Report

Merging #1107 (c3157f7) into dev (f64b26d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1107   +/-   ##
=======================================
  Coverage   80.04%   80.04%           
=======================================
  Files         197      197           
  Lines        5392     5392           
=======================================
  Hits         4316     4316           
  Misses       1076     1076
Impacted Files Coverage Δ
zhaquirks/tuya/ts011f_plug.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f64b26d...c3157f7. Read the comment docs.

@MattWestb
Copy link
Contributor

BINGO !!! :-))

@coveralls
Copy link

coveralls commented Oct 28, 2021 •
edited

Pull Request Test Coverage Report for Build 1394148141

  • 3 of 3 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 80.045%
Totals Coverage Status
Change from base Build 1385828645: 0.0%
Covered Lines: 4316
Relevant Lines: 5392
💛 - Coveralls

@miit86
Copy link
Contributor Author

miit86 commented Oct 28, 2021

@MattWestb
Just a minor change to get the AC reading OK

@MattWestb
Copy link
Contributor

I have seen.

Now the test is running then you is doing commits to the PR as long no one is demanding changes and its making it easier working with PRs :-))

@miit86 miit86 mentioned this pull request Oct 28, 2021
Closed
@miit86
Update ts011f_plug.py
0d6fbaa 
Removed the Custom Cluster for Electrical Measurement to fix AC_Voltage
@miit86
Update ts011f_plug.py
a518fa1 
Fix for Current
@miit86
Update ts011f_plug.py
c3157f7 
fixed naming
@miit86
Update ts011f_plug.py
6f99920 
fix black
@miit86
Copy link
Contributor Author

miit86 commented Oct 28, 2021 •
edited

Fixed and Tested:
Fixes #1108

image

@dmulcahey dmulcahey merged commit fed86dd into zigpy:dev Oct 28, 2021
@Hedda Hedda mentioned this pull request Oct 29, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmulcahey dmulcahey dmulcahey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@miit86 @codecov-commenter @MattWestb @coveralls @dmulcahey