Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add D5X84YU to Danfoss quirk #1148

Merged
merged 3 commits into from Nov 13, 2021

Conversation

hertleinj
Copy link
Contributor

Bought two of the Danfoss thermostats under the oem named Popp .
Without the updated quirks no updates could be triggered from HA.
After the changes updateing from HA works flawless (at least the last day).
The already working way thermostat -> HA still works.

Popp Danfoss was also already mentioned in #1005

First try more than open for input. Ty.

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2021

Codecov Report

Merging #1148 (5922650) into dev (242d5f3) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1148   +/-   ##
=======================================
  Coverage   80.23%   80.23%           
=======================================
  Files         197      197           
  Lines        5438     5439    +1     
=======================================
+ Hits         4363     4364    +1     
  Misses       1075     1075           
Impacted Files Coverage Δ
zhaquirks/danfoss/__init__.py 100.00% <100.00%> (ø)
zhaquirks/danfoss/thermostat.py 79.16% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242d5f3...5922650. Read the comment docs.

@coveralls
Copy link

coveralls commented Nov 13, 2021

Pull Request Test Coverage Report for Build 1455796401

  • 2 of 2 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.004%) to 80.235%

Totals Coverage Status
Change from base Build 1449277742: 0.004%
Covered Lines: 4364
Relevant Lines: 5439

💛 - Coveralls

@MattWestb
Copy link
Contributor

I was trying adding it and the Hive TRV that also shall being the same hard and software but was not getting positive feedback from the user so i was not posing the PR.
If you like you can adding it in the same PR or we doing it then user is asking for it.

zigpy/zigpy#840 (comment)

Well done !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants