Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quirks for Foluu Smart Thermostatic Valve Regulator #1753

Merged
merged 1 commit into from
Sep 25, 2022
Merged

Quirks for Foluu Smart Thermostatic Valve Regulator #1753

merged 1 commit into from
Sep 25, 2022

Conversation

l0wl3vel
Copy link
Contributor

Tested using Home Assistant + ZHA

Seems to be an Zonnsmart style TV05-ZG as described here

Link to Product: Amazon.de

@coveralls
Copy link

coveralls commented Sep 14, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3067008368

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 71.609%
Totals Coverage Status
Change from base Build 3040106202: 0.0%
Covered Lines: 5269
Relevant Lines: 7358
💛 - Coveralls

MattWestb
MattWestb approved these changes Sep 14, 2022
View reviewed changes
Copy link
Contributor

@MattWestb MattWestb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to my and have adding it in tuya TRV matrix as Foluu TV05 as one clone of Zonnsmart TRV.

@MattWestb
Copy link
Contributor

By the way you is having some extra chaster or tabs in the added code.
Copy this over the new added line then its "clean" and shall passing the tests:

            ("_TZE200_mudxchsu", "TS0601"),

@javicalle
Copy link
Collaborator

It seems to be the final colon

@l0wl3vel
Copy link
Contributor Author

Where can I find the support matrix?

@MattWestb
Copy link
Contributor

Now all looks very nice !!!

Its in one discussion for trying getting little structure if the tuya mess of there TRVs.
zigpy/zigpy#653 (comment)

@dmulcahey dmulcahey merged commit cd542ca into zigpy:dev Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmulcahey dmulcahey dmulcahey approved these changes

@MattWestb MattWestb MattWestb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@l0wl3vel @coveralls @MattWestb @javicalle @dmulcahey