Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E1525 Zigbee 3 update #2137

Merged
merged 3 commits into from Jan 26, 2023
Merged

E1525 Zigbee 3 update #2137

merged 3 commits into from Jan 26, 2023

Conversation

MattWestb
Copy link
Contributor

Now IKEA is all Zigbee 3.

As expected it have loosing group binding and reporting wrong battery %. Delete the device in ZHA and waiting one minute and adding it new and reconfigure it then its OK pared and its start reporting OK and also is doing check ins every 55 minute.

### Now IKEA is all Zigbee 3.
As expected it have loosing group binding and reporting wrong battery %.
Delete the device in ZHA and waiting one minute and adding it new and reconfigure it then its OK pared and its start reporting OK and also is doing check ins every 55 minute.
@coveralls
Copy link

coveralls commented Jan 26, 2023

Pull Request Test Coverage Report for Build 4019112824

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.006%) to 83.702%

Totals Coverage Status
Change from base Build 4016912078: 0.006%
Covered Lines: 6887
Relevant Lines: 8228

💛 - Coveralls

@codecov-commenter
Copy link

codecov-commenter commented Jan 26, 2023

Codecov Report

Base: 83.69% // Head: 83.70% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (b8895cc) compared to base (6b8cd2c).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #2137   +/-   ##
=======================================
  Coverage   83.69%   83.70%           
=======================================
  Files         258      258           
  Lines        8225     8228    +3     
=======================================
+ Hits         6884     6887    +3     
  Misses       1341     1341           
Impacted Files Coverage Δ
zhaquirks/ikea/motionzha.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MattWestb
Copy link
Contributor Author

MattWestb commented Jan 26, 2023

With new firmware and updated quirk:

Device info
TRADFRI motion sensor
by IKEA of Sweden
Connected via Billy RCP 4.2.0 RK3318
Firmware: 0x24040005
Zigbee info
IEEE: 90:fd:9f:ff:fe:59:bb:73
Nwk: 0x4544
Device Type: EndDevice
LQI: 200
RSSI: -55
Last Seen: 2023-01-26T21:10:21
Power Source: Battery or Unknown
Quirk: motionzha.IkeaTradfriMotionE1525

Edit: LQI and batters looks being OK reported.

@TheJulianJES
Copy link
Collaborator

TheJulianJES commented Jan 26, 2023

Do we maybe also want to rename the quirk/class in line 25 to IkeaTradfriMotionE1745_1 (assuming it's for that model) and line 92 to IkeaTradfriMotionE1745_2? (Other IKEA remote just append V1/V2 but I feel like an underscore is better here, so it doesn't get confused with the model.

And/or maybe update the docstring in quotes to mention the model?

(Line 36 also has a wrong comment about a remote control)

@javicalle
Copy link
Collaborator

Or maybe just IkeaTradfriMotion, IkeaTradfriMotion_Var02, IkeaTradfriMotion_Var03, ...

That Var states for 'variation'. I prefer it before 'version' which can appear to be new versions of the device.
I would also remove the device code as a generic rule.

Copy link
Collaborator

@javicalle javicalle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MattWestb
Copy link
Contributor Author

MattWestb commented Jan 26, 2023

Have putting the good from both comment in naming and dock strings.

Edit: Was putting in first / second gen so its easy knowing witch it is and very likely is coming one third gen very soon (updated Zigbee module and more from reddit pull).

@TheJulianJES TheJulianJES merged commit 07f38fc into zigpy:dev Jan 26, 2023
@MattWestb
Copy link
Contributor Author

Thanks J & J !!

@MattWestb MattWestb deleted the patch-1 branch January 26, 2023 21:52
@MattWestb
Copy link
Contributor Author

Only for documentation the signature for the E1745 updated with Dirigera (no released in TFGW OTA feed).

    "signature": {
      "node_descriptor": "NodeDescriptor(logical_type=<LogicalType.EndDevice: 2>, complex_descriptor_available=0, user_descriptor_available=0, reserved=0, aps_flags=0, frequency_band=<FrequencyBand.Freq2400MHz: 8>, mac_capability_flags=<MACCapabilityFlags.AllocateAddress: 128>, manufacturer_code=4476, maximum_buffer_size=82, maximum_incoming_transfer_size=82, server_mask=11264, maximum_outgoing_transfer_size=82, descriptor_capability_field=<DescriptorCapability.NONE: 0>, *allocate_address=True, *is_alternate_pan_coordinator=False, *is_coordinator=False, *is_end_device=True, *is_full_function_device=False, *is_mains_powered=False, *is_receiver_on_when_idle=False, *is_router=False, *is_security_capable=False)",
      "endpoints": {
        "1": {
          "profile_id": 260,
          "device_type": "0x0850",
          "in_clusters": [
            "0x0000",
            "0x0001",
            "0x0003",
            "0x0020",
            "0x1000",
            "0xfc57",
            "0xfc7c"
          ],
          "out_clusters": [
            "0x0003",
            "0x0004",
            "0x0006",
            "0x0008",
            "0x0019",
            "0x1000"
          ]
        }
      }
    },

and the device card:

Device info
TRADFRI motion sensor
by IKEA of Sweden
Connected via [Billy RCP 4.2.1 RK3228A](http://192.168.2.65:8123/config/devices/device/e96ce063acfe580c70ca981efa995aab)
Firmware: 0x24040005
Zigbee info
IEEE: cc:cc:cc:ff:fe:c1:3a:8c
Nwk: 0x2f6f
Device Type: EndDevice
LQI: 196
RSSI: -60
Last Seen: 2023-02-16T09:30:39
Power Source: Battery or Unknown

Its very tricky getting pared (resetting the device is nearly impossible) and then is the best is taking the battery out and doing one reconfigure then putting them back for getting it reporting OK.
No quirk is loaded but battery looks being reported OK as Zigbee standard and motion detected if bright or not.

Z2M user is also reporting that the Dirigera is updating the blinds to the new standard but we dont knowing the URL for the update server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants