TRADFRI remote control - add fw support v24.4.5 #2140

stickpin · 2023-01-27T15:43:01Z

TRADFRI remote control - Add support for firmware v24.4.5

More details in this bug report: #2139

codecov-commenter · 2023-01-27T15:46:28Z

Codecov Report

Base: 83.70% // Head: 83.70% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (67e6ef7) compared to base (07f38fc).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

@@           Coverage Diff           @@
##              dev    #2140   +/-   ##
=======================================
  Coverage   83.70%   83.70%           
=======================================
  Files         258      258           
  Lines        8228     8232    +4     
=======================================
+ Hits         6887     6891    +4     
  Misses       1341     1341

Impacted Files	Coverage Δ
zhaquirks/ikea/fivebtnremotezha.py	`100.00% <100.00%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

coveralls · 2023-01-27T16:17:23Z

Pull Request Test Coverage Report for Build 4027420412

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage increased (+0.008%) to 83.71%

Totals
Change from base Build 4019454703:	0.008%
Covered Lines:	6891
Relevant Lines:	8232

💛 - Coveralls

MattWestb · 2023-01-27T18:11:25Z

Thanks for the updated quirk i have the same done nut i have portable verifying that is working then the remote was not liking upgrading to the last OTA and after flashing it with the last good with group supported my ZHA with RCP firmware 4.1.4 and 4.2.0 dont like paring it so i must sniffing what is going wrong.

Device class naming i do not comments then its one question for the maintainers.

PS: is one risk that you need rebasing your PR then its one in the pipe for merger that is fixing some old DA and raking some unneeded things away.
#2123

stickpin · 2023-01-27T18:27:22Z

Thanks for the updated quirk i have the same done nut i have portable verifying that is working then the remote was not liking upgrading to the last OTA and after flashing it with the last good with group supported my ZHA with RCP firmware 4.1.4 and 4.2.0 dont like paring it so i must sniffing what is going wrong.

Device class naming i do not comments then its one question for the maintainers.

PS: is one risk that you need rebasing your PR then its one in the pipe for merger that is fixing some old DA and raking some unneeded things away. #2123

No problem, I will rebase it once it's merged.

There is still a problem with the battery reporting.

It looks like IKEA changed measurement from percentage 0-100 to 0-255. Meaning that we need a convertor in the quirk for this now as well. I am new to quirks, so I will see what is the best way to implement the converter.

TheJulianJES · 2023-01-27T18:34:52Z

Yeah, check the PowerConfiguration1CRCluster you're using.

ZCL requires 0—200 for battery and. Is it possible that IKEA uses those correct values now? (Or where are you getting the 255?)

stickpin · 2023-01-27T18:39:49Z

Yeah, check the PowerConfiguration1CRCluster you're using.

ZCL requires 0—200 for battery and. Is it possible that IKEA uses those correct values now? (Or where are you getting the 255?)

Yes, you are right. I've just changed to the new battery and checked the PowerConfiguration1CRCluster:

Should we just divide the value by 2?

TheJulianJES · 2023-01-27T18:54:52Z

0 to 200 should be what ZHA expects (and will divide that by 2 per ZCL spec).

So right now your quirk is overriding the PowerConfiguration cluster with the custom PowerConfiguration1CRCluster.
What happens if you also put PowerConfiguration.cluster_id in the replacement (instead of PowerConfiguration1CRCluster)?

~~EDIT: Actually, I may have confused this with Xiaomi gear(?)~~

MattWestb · 2023-01-27T18:56:47Z

All IKEA controller is reporting 100% then full and ZCL it shall being reported 200 for being full so all IKEA quirks is id dubeling the reported valiue.
Its looks like some Z2M user have reported that the new firmware is ZCL and dont need the doubling but i have not verifying that.

stickpin · 2023-01-27T19:10:16Z

@TheJulianJES, @MattWestb thanks a lot for the hint!
It worked!

I've updated the quirk.

TheJulianJES · 2023-01-28T00:42:00Z

Its looks like some Z2M user have reported that the new firmware is ZCL

Also, the updated remote reports zcl_version = 8 (ZCL revision 8), so IKEA finally used a way newer EmberZNet release to build this firmware and even used this for their older products. (yay)
(Hoping IKEA also does this for every other 2.x.x products. STARKVIND and other 1.x firmware products already report zcl_version = 8)

Weirdly for me, the remote didn't get the new signature after re-pairing. It shouldn't require me to delete the remote first though. (I'll look at this later)

MattWestb · 2023-01-28T11:29:16Z

I still fighting getting the old firmware on the Zigbee module also the very old ZLL 1.1.1 that i have "found".
In the end its looks Segger have changing there libs and silabs have updating then with the last SS5 updates and now its required having hardware reset for loading the CPU code and flashing MG1 device that was not needed before. So i must braking it more and souring cables then i cant hold 5 jumpers in place and start flashing with the other hand :-(((

Great that the quirk looks being in place so user can installing it and using there devices !!!

MattWestb · 2023-01-29T14:09:15Z

Have getting the WSTK working after getting the PCB out and back with cables so can flashing it OK. The TRADFRI-remote-control-1111 is not starting OK (one very old TLL firmware and very likely is the bootloader to new for it).
The last TRADFRI-remote-control-2.3.080 was Ember Version: 6.3.1.1 and the update is Ember Version: 6.10.2.0 = many battery draining bugs and network problems.
The TRADFRI-motion-sensor-24.4.5 is also Ember Version: 6.10.2.0 so its all great only that IKEA can have one small step to 6.10.3 but i cant complaining.

I trying OTA updating from 2.3.80 and its taking some time if its working OK.

The Starkvind OTA file is in GBL format and is not having any metadata for the compiling.
But in the release note:

Release Version: 1.22.0 GA
- 6th Sep 2022
  - STARKVIND Air Purifier (v1.1.001)
  - Upgrade to stack v6.10.2.

I think it can being one more problem with very old devices is having old bootloaders that making hard flashing 7.X firmware and 7.1 have dropping all Zigbee support for MG1 (first and second gen devices) devices but i being very happy with 6.10.X :-)))
I think the first gen need EBL files for the bootloader and second and 3 gen can using GBL files.
Also its possible updating the bootloader with OTA but Silbas is not recommending it then its not 100% sure its working OK and getting hardware bricking.

For third gen devices have not limit if have making all right.

MattWestb · 2023-01-30T13:55:12Z

I have testing and doing automatons from all DAs and they is working !!!

If some line doing more DAs its possible for dim up and down release:

up relese

  endpoint_id: 1
  cluster_id: 8
  command: stop_with_on_off
  args: []
  params: {}


down relese

  endpoint_id: 1
  cluster_id: 8
  command: stop
  args:
    - 0
    - 0
  params:
    options_mask: 0
    options_override: 0

is always the same and is unique = can being used for dim up / down released after long press.

Long release for left / right hold is also possible but little tricky is sending:

Left release:

  endpoint_id: 1
  cluster_id: 5
  command: release
  args:
    - 4112
  params:
    param1: 4112


Right release:

  endpoint_id: 1
  cluster_id: 5
  command: release
  args:
    - 3548
  params:
    param1: 3548

And the parm1 / arg is the time the button was hold. The problem is that 0 is being used for toggle long press / release but can filtering 0 away and it shall working.
Getting release from right left its possible using the same logic as Open / Close button that is saving the last direction and using it for next release.

Great work done !!

MattWestb

Also battery is working OK (10% after firmware up and downgrade many times ).

MattWestb · 2023-01-30T13:59:48Z

The reseal from hold dim up and down is one PR for adding in current devices so i think its good putting in here 2.
https://github.com/zigpy/zha-device-handlers/pull/2123/files

MattWestb

Not one must but its easy adding the dim up and down release after hold.

MattWestb · 2023-01-30T14:21:45Z

zhaquirks/ikea/fivebtnremotezha.py

+            CLUSTER_ID: 8,
+            ENDPOINT_ID: 1,
+            PARAMS: {"move_mode": 0},
+        },


(LONG_RELEASE, DIM_UP): { COMMAND: COMMAND_STOP_ON_OFF, CLUSTER_ID: 8, ENDPOINT_ID: 1, },

MattWestb · 2023-01-30T14:22:05Z

zhaquirks/ikea/fivebtnremotezha.py

+            CLUSTER_ID: 8,
+            ENDPOINT_ID: 1,
+            PARAMS: {"move_mode": 1},
+        },


(LONG_RELEASE, DIM_DOWN): { COMMAND: COMMAND_STOP, CLUSTER_ID: 8, ENDPOINT_ID: 1, },

TheJulianJES · 2023-01-30T14:25:03Z

Let's try and wait for #2123 first. Then, this can be rebased and hopefully just copy all device automation triggers.

MattWestb · 2023-01-31T08:31:06Z

@stickpin Can you reading the hw_version (id: 0x0003) attribute on basic cluster on your device ?
The firmware have getting CSA certificate but is written Hardware Version 2 and my is ver 1 and was not liking the OTA and was rolling it back (it shall not downloading it if the HW Ver is not OK if have setting it as moderate).
https://csa-iot.org/csa_product/tradfri-remote-control-11/

stickpin · 2023-01-31T08:34:29Z

@MattWestb

MattWestb · 2023-01-31T10:01:47Z

Thanks then i think my remote have one older bootloader that making the OTA not being installed normal way.

stickpin mentioned this pull request Jan 27, 2023

[BUG] Issues with TRADFRI remote control and latest firmware 24.4.5 #2139

Closed

MattWestb mentioned this pull request Jan 29, 2023

Tradfri remote control shows battery level of 130% home-assistant/core#86880

Closed

MattWestb approved these changes Jan 30, 2023

View reviewed changes

MattWestb mentioned this pull request Jan 30, 2023

Add "long release event" for IKEA 5-button remotes #2123

Merged

MattWestb reviewed Jan 30, 2023

View reviewed changes

stickpin added a commit to stickpin/zha-device-handlers that referenced this pull request Jan 30, 2023

merge PR zigpy#2123 and PR zigpy#2140

f001fe6

stickpin mentioned this pull request Jan 30, 2023

Merge PR #2123 and PR #2140 + fivebtnremote files merge #2152

Closed

TheJulianJES mentioned this pull request Jan 31, 2023

Refactor IKEA five button remote quirks #2155

Merged

stickpin closed this Jan 31, 2023

stickpin force-pushed the patch-1 branch from 9271724 to 7e81dcb Compare January 31, 2023 15:45

stickpin mentioned this pull request Jan 31, 2023

TRADFRI remote control - add fw support v24.4.5 #2156

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TRADFRI remote control - add fw support v24.4.5 #2140

TRADFRI remote control - add fw support v24.4.5 #2140

stickpin commented Jan 27, 2023

codecov-commenter commented Jan 27, 2023

coveralls commented Jan 27, 2023 •

edited

MattWestb commented Jan 27, 2023

stickpin commented Jan 27, 2023 •

edited

TheJulianJES commented Jan 27, 2023 •

edited

stickpin commented Jan 27, 2023 •

edited

TheJulianJES commented Jan 27, 2023 •

edited

MattWestb commented Jan 27, 2023

stickpin commented Jan 27, 2023

TheJulianJES commented Jan 28, 2023

MattWestb commented Jan 28, 2023

MattWestb commented Jan 29, 2023

MattWestb commented Jan 30, 2023

MattWestb left a comment

MattWestb commented Jan 30, 2023

MattWestb left a comment

MattWestb Jan 30, 2023

MattWestb Jan 30, 2023

TheJulianJES commented Jan 30, 2023

MattWestb commented Jan 31, 2023 •

edited

stickpin commented Jan 31, 2023

MattWestb commented Jan 31, 2023

TRADFRI remote control - add fw support v24.4.5 #2140

TRADFRI remote control - add fw support v24.4.5 #2140

Conversation

stickpin commented Jan 27, 2023

codecov-commenter commented Jan 27, 2023

Codecov Report

coveralls commented Jan 27, 2023 • edited

Pull Request Test Coverage Report for Build 4027420412

💛 - Coveralls

MattWestb commented Jan 27, 2023

stickpin commented Jan 27, 2023 • edited

TheJulianJES commented Jan 27, 2023 • edited

stickpin commented Jan 27, 2023 • edited

TheJulianJES commented Jan 27, 2023 • edited

MattWestb commented Jan 27, 2023

stickpin commented Jan 27, 2023

TheJulianJES commented Jan 28, 2023

MattWestb commented Jan 28, 2023

MattWestb commented Jan 29, 2023

MattWestb commented Jan 30, 2023

MattWestb left a comment

Choose a reason for hiding this comment

MattWestb commented Jan 30, 2023

MattWestb left a comment

Choose a reason for hiding this comment

MattWestb Jan 30, 2023

Choose a reason for hiding this comment

MattWestb Jan 30, 2023

Choose a reason for hiding this comment

TheJulianJES commented Jan 30, 2023

MattWestb commented Jan 31, 2023 • edited

stickpin commented Jan 31, 2023

MattWestb commented Jan 31, 2023

coveralls commented Jan 27, 2023 •

edited

stickpin commented Jan 27, 2023 •

edited

TheJulianJES commented Jan 27, 2023 •

edited

stickpin commented Jan 27, 2023 •

edited

TheJulianJES commented Jan 27, 2023 •

edited

MattWestb commented Jan 31, 2023 •

edited