Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enumerates Zigbee Green Power profile and device types in existing quirks #2414

Merged
merged 46 commits into from Jun 7, 2023

Conversation

nworbneb
Copy link
Contributor

@nworbneb nworbneb commented May 29, 2023

Proposed change

This is purely a documentation excercise, to enhance readability of quirks, with no functional impact.

Additional information

Requires merged zigpy pull to add Zigbee Green Power enumerations (zigpy/zigpy#1213)

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

@nworbneb
Copy link
Contributor Author

nworbneb commented May 29, 2023

I suspect this will take a little time for the necessary pull to make it into latest zigpy and the CI requirements to be updated to allow it to run successfully.

My intention, once included, is to circle back in a month or so to catch any in-flight pull requests, such as #2336

@Hedda
Copy link
Contributor

Hedda commented Jun 5, 2023

Requires merged zigpy pull to add Zigbee Green Power enumerations (zigpy/zigpy#1213)

Maybe make a draft for now as dependent on the currently unreleased zigpy 0.56.0 library which will contain zigpy/zigpy#1213 ?

PS: If possible please also update the ZGP feature request discussion for zigpy library here -> zigpy/zigpy#341

@Hedda
Copy link
Contributor

Hedda commented Jun 5, 2023

@zoic21 have you had a chance to try zigpy/zigpy#1213 and #2414 with your Zigbee plugin for Jeedom? As I understand these should hopefully make your zigpy ZGP patches in Jeedom from zigpy/zigpy#656 (previously zigpy/zigpy#519) unnecessary, or?

@dmulcahey
Copy link
Collaborator

Thanks for this!!

@dmulcahey dmulcahey merged commit 2d05ca8 into zigpy:dev Jun 7, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants