Add support for _TZE204_sxm7l9xa #2485

arbrandes · 2023-07-21T12:24:13Z

Proposed change

This primarily adds support for the _TZE204_sxm7l9xa Tuya millimeter wave sensor, and in doing so moves TS0601 radar support out of ts0601_motion.py to its own file, ts0601_radar.py.

This should also add control support to previously supported devices.

Additional information

This is a mashup of proposed quirks found mostly on #2378.

Checklist

The changes are tested and work correctly
pre-commit checks pass / the code has been formatted using Black
Tests have been added to verify that the new code works

arbrandes · 2023-07-21T13:19:33Z

Ok, I'll have to figure out later where we're duplicating 0x000C in the endpoint replacements. Otherwise, this seems to work with my devices when the file as-is is dropped in as a local quirk on Home Assistant 2023.7.2.

(Thought this might be an easy port, but I'm still too much of a quirk newb.)

)

TheJulianJES · 2023-07-26T19:58:52Z

zhaquirks/tuya/ts0601_motion.py

+                    TuyaMmwRadarTargetDistance,
+                    TuyaMmwRadarSensitivity,


The AnalogInput cluster ID (extended) is duplicated here.
This Tuya stuff is already somewhat of a workaround everywhere. Are both clusters working correctly here like this?

It seems to work, yes, though in any case I now removed AnalogInput from the cluster. Not sure if the duplication is gone: I don't think all the tests are running against this PR.

ingulacrist · 2023-07-26T22:28:43Z

zhaquirks/tuya/ts0601_motion.py

@@ -398,6 +565,7 @@ class MmwRadarMotionGPP(CustomDevice):
            ("_TZE200_ar0slwnd", "TS0601"),
            ("_TZE200_sfiy5tfs", "TS0601"),
            ("_TZE200_mrf6vtua", "TS0601"),
+            ("_TZE204_sxm7l9xa", "TS0601"),


("_TZE204_qasjif9e", "TS0601"), can be added here as well.
I tested locally on my machine and the sensor _TZE204_qasjif9e works perfectly with this quirk.

_TZE204_qasjif9e is not the same as the other devices, the main properties are, however the settings are different and can't be changed this way

Yeah. @pgroene has been kind enough to provide a separate PR for that one. 👍🏼

isoutham · 2023-08-09T09:30:15Z

Just to conform this patch fixes ZHA integration for _TZE204_qasjif9e (motion_sensor)

rrooggiieerr · 2023-08-25T10:10:36Z

Hi! I'm using this patch for my _TZE204_sxm7l9xa and Occupancy, Detection Delay, Min Range and Max Range are working, however Fading Time and Sensitivity are always set back to 53000 mili seconds and 9, changing these values doesn't work. Also Illuminance is not working.

For the quirk mentioned here Illuminance does work but Occupancy doesn't.

seanw18 · 2023-08-26T04:20:25Z

Hi! I'm using this patch for my _TZE204_sxm7l9xa and Occupancy, Detection Delay, Min Range and Max Range are working, however Fading Time and Sensitivity are always set back to 53000 mili seconds and 9, changing these values doesn't work. Also Illuminance is not working.

Thanks @rrooggiieerr

I've tried this quirk (after removing, restarting, and re-adding device) and I still don't seem to get the ability to change behaviour via "max range".

danieljonce · 2023-09-02T16:17:11Z

Thanks for the work on this! I can confirm the occupancy detection is working on my _TZE204_sxm7l9xa. For me all five sliders all seem to reset their values after the occupancy changes state.

And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices

codecov · 2023-09-04T22:00:13Z

Codecov Report

Patch coverage: 62.35% and project coverage change: -0.28% ⚠️

Comparison is base (f99806a) 86.54% compared to head (4c40dba) 86.26%.

Additional details and impacted files

@@            Coverage Diff             @@
##              dev    #2485      +/-   ##
==========================================
- Coverage   86.54%   86.26%   -0.28%     
==========================================
  Files         276      277       +1     
  Lines        8502     8564      +62     
==========================================
+ Hits         7358     7388      +30     
- Misses       1144     1176      +32

Files Changed	Coverage Δ
zhaquirks/tuya/ts0601_radar.py	`61.44% <61.44%> (ø)`
zhaquirks/tuya/ts0601_motion.py	`100.00% <100.00%> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices

arbrandes · 2023-09-04T22:11:47Z

@danieljonce, @seanw18

For me all five sliders all seem to reset their values after the occupancy changes state.

I just updated the PR to fix this, based on some more info I found laying around. It should now be possible to actually change settings on _TZE204_sxm7l9xa.

danieljonce · 2023-09-09T16:11:06Z

@arbrandes

I just updated the PR to fix this, based on some more info I found laying around. It should now be possible to actually change settings on _TZE204_sxm7l9xa.

I can confirm that after removing and re-adding my _TZE204_sxm7l9xa in ZHA while having only the ts0601_radar.py file from the commit 4c40dba in the custom quirks folder:

Slider settings are saved as expected
Presence works
Lux works (after a whole system restart)

Thanks again!

TheJulianJES · 2023-10-05T15:42:36Z

So #2525 somewhat copied some of this. Since my review comments aren't addressed there (yet?), can you take a look at them? (They mostly apply to this PR too, especially: https://github.com/zigpy/zha-device-handlers/pull/2525/files#r1340849012)

Kefut · 2023-11-07T20:46:32Z

@arbrandes

I just updated the PR to fix this, based on some more info I found laying around. It should now be possible to actually change settings on _TZE204_sxm7l9xa.

I can confirm that after removing and re-adding my _TZE204_sxm7l9xa in ZHA while having only the ts0601_radar.py file from the commit 4c40dba in the custom quirks folder:

Slider settings are saved as expected

Presence works

Lux works (after a whole system restart)

Thanks again!

Did you get target distance working as well? If so, how?

Kefut · 2023-11-09T07:25:17Z

Adding to my last question, one very basic question:
Where can I find general information on how quirks a created/structured. I cannot figure it out 100% by just reading the one above, but would like to understand why I don't see Target distance and illuminance for my _TZE204_ztc6ggyl using this quirk.

Eiritj · 2023-11-27T19:47:25Z

Any chance this sensor can be supported natively without using quirks?

adey · 2024-03-23T15:29:41Z

Using this quirk have been successful in adding the device. But somehow it keeps going offline and then coming back online frequently. This is my only zigbee device does this out of about 50 devices I have integrated via ZHA.

Any tips on how to fix this?
Thanks.

chimeranzl · 2024-04-10T01:18:54Z

Can you add support for _TZE204_mtoaryre please? I tried adding to signatures in .py, it picks up the sensor but all entities are missing

arbrandes mentioned this pull request Jul 21, 2023

[Device Support Request] ZY-M100 #2378

Open

TheJulianJES added the Tuya Request/PR regarding a Tuya device label Jul 21, 2023

arbrandes force-pushed the ts0601-motion branch 5 times, most recently from d47ce54 to 3c56b06 Compare July 21, 2023 13:10

arbrandes added a commit to arbrandes/zha-device-handlers that referenced this pull request Jul 21, 2023

Add support for more TS0601 motion sensors and configuration (zigpy#2485

6cf22f6

)

arbrandes force-pushed the ts0601-motion branch from 3c56b06 to 6cf22f6 Compare July 21, 2023 13:22

arbrandes changed the title ~~Add support for more TS0601 sensors and configuration (#2378)~~ Add support for more TS0601 sensors and configuration Jul 21, 2023

arbrandes added a commit to arbrandes/zha-device-handlers that referenced this pull request Jul 25, 2023

Add support for more TS0601 motion sensors and configuration (zigpy#2485

b2c5ead

)

arbrandes force-pushed the ts0601-motion branch from 6cf22f6 to b2c5ead Compare July 25, 2023 19:38

TheJulianJES reviewed Jul 26, 2023

View reviewed changes

ingulacrist reviewed Jul 26, 2023

View reviewed changes

Woll3 mentioned this pull request Aug 25, 2023

[Device Support Request] Tuya Zigbee Human Presence Sensor. TS0601 by _TZE204_sxm7l9xa #2429

Open

arbrandes added a commit to arbrandes/zha-device-handlers that referenced this pull request Sep 4, 2023

Add support for _TZE204_sxm7l9xa (zigpy#2485)

0793273

And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices

arbrandes force-pushed the ts0601-motion branch from b2c5ead to 0793273 Compare September 4, 2023 21:57

arbrandes changed the title ~~Add support for more TS0601 sensors and configuration~~ Add support for _TZE204_sxm7l9xa Sep 4, 2023

arbrandes added a commit to arbrandes/zha-device-handlers that referenced this pull request Sep 4, 2023

Add support for _TZE204_sxm7l9xa (zigpy#2485)

1ef4b11

And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices

arbrandes force-pushed the ts0601-motion branch from 0793273 to 1ef4b11 Compare September 4, 2023 22:07

Add support for _TZE204_sxm7l9xa (zigpy#2485)

4c40dba

And in doing so: * Move the Tuya MMW radar devices to their own file * Get the controls working for more devices

arbrandes force-pushed the ts0601-motion branch from 1ef4b11 to 4c40dba Compare September 4, 2023 22:10

pgroene mentioned this pull request Sep 6, 2023

Add support for Tuya MMW sensors: _TZE204_qasjif9e, _TZE204_sxm7l9xa, _TZE204_e5m9c5hl #2525

Open

3 tasks

BeckoPopov approved these changes Sep 19, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for _TZE204_sxm7l9xa #2485

Add support for _TZE204_sxm7l9xa #2485

arbrandes commented Jul 21, 2023 •

edited

arbrandes commented Jul 21, 2023 •

edited

TheJulianJES Jul 26, 2023

arbrandes Sep 4, 2023

ingulacrist Jul 26, 2023

pgroene Aug 14, 2023

arbrandes Sep 4, 2023 •

edited

isoutham commented Aug 9, 2023

rrooggiieerr commented Aug 25, 2023

seanw18 commented Aug 26, 2023

danieljonce commented Sep 2, 2023

codecov bot commented Sep 4, 2023 •

edited

arbrandes commented Sep 4, 2023 •

edited

danieljonce commented Sep 9, 2023

TheJulianJES commented Oct 5, 2023

Kefut commented Nov 7, 2023

Kefut commented Nov 9, 2023

Eiritj commented Nov 27, 2023

adey commented Mar 23, 2024 •

edited

chimeranzl commented Apr 10, 2024

Add support for _TZE204_sxm7l9xa #2485

Are you sure you want to change the base?

Add support for _TZE204_sxm7l9xa #2485

Conversation

arbrandes commented Jul 21, 2023 • edited

Proposed change

Additional information

Checklist

arbrandes commented Jul 21, 2023 • edited

TheJulianJES Jul 26, 2023

Choose a reason for hiding this comment

arbrandes Sep 4, 2023

Choose a reason for hiding this comment

ingulacrist Jul 26, 2023

Choose a reason for hiding this comment

pgroene Aug 14, 2023

Choose a reason for hiding this comment

arbrandes Sep 4, 2023 • edited

Choose a reason for hiding this comment

isoutham commented Aug 9, 2023

rrooggiieerr commented Aug 25, 2023

seanw18 commented Aug 26, 2023

danieljonce commented Sep 2, 2023

codecov bot commented Sep 4, 2023 • edited

Codecov Report

arbrandes commented Sep 4, 2023 • edited

danieljonce commented Sep 9, 2023

TheJulianJES commented Oct 5, 2023

Kefut commented Nov 7, 2023

Kefut commented Nov 9, 2023

Eiritj commented Nov 27, 2023

adey commented Mar 23, 2024 • edited

chimeranzl commented Apr 10, 2024

arbrandes commented Jul 21, 2023 •

edited

arbrandes commented Jul 21, 2023 •

edited

arbrandes Sep 4, 2023 •

edited

codecov bot commented Sep 4, 2023 •

edited

arbrandes commented Sep 4, 2023 •

edited

adey commented Mar 23, 2024 •

edited