Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for TS0049 Tuya Water Valve #2624

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Conversation

danpeig
Copy link

@danpeig danpeig commented Oct 5, 2023

For more details refer to this issue:
#2377

Proposed change

Added suport for TS0049 Water Valve from Tuya.

Additional information

This handler was proposed by the users of the issue 2377 and after a few months around, we believe it is quite stable to be included in the final list.

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works

For more details refer to this issue:
zigpy#2377
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Attention: Patch coverage is 81.48148% with 5 lines in your changes missing coverage. Please review.

Project coverage is 88.66%. Comparing base (10a17d3) to head (2413e14).
Report is 147 commits behind head on dev.

Files Patch % Lines
zhaquirks/tuya/ts0049.py 81.48% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #2624      +/-   ##
==========================================
+ Coverage   86.59%   88.66%   +2.07%     
==========================================
  Files         277      305      +28     
  Lines        8531    12451    +3920     
==========================================
+ Hits         7387    11040    +3653     
- Misses       1144     1411     +267     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES added the Tuya Request/PR regarding a Tuya device label Oct 8, 2023
@TheJulianJES TheJulianJES added the hacktoberfest-accepted PR is accepted to count towards the Hacktoberfest PR count. label Oct 24, 2023
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. Thank you for your contributions.

@github-actions github-actions bot added the stale Issue is inactivate and might get closed soon label Apr 21, 2024
@github-actions github-actions bot closed this Apr 28, 2024
@TheJulianJES TheJulianJES removed the stale Issue is inactivate and might get closed soon label Apr 28, 2024
@TheJulianJES TheJulianJES reopened this Apr 28, 2024
@TheJulianJES
Copy link
Collaborator

This needs a few changes (especially test coverage), but I still want to take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted PR is accepted to count towards the Hacktoberfest PR count. Tuya Request/PR regarding a Tuya device
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants