Use config dataclasses instead of HA dicts #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #43 +/- ##
==========================================
+ Coverage 94.75% 94.81% +0.06%
==========================================
Files 61 61
Lines 9200 9192 -8
==========================================
- Hits 8717 8715 -2
+ Misses 483 477 -6 ☔ View full report in Codecov by Sentry. |
puddly
reviewed
Apr 8, 2024
| @@ -502,7 +498,7 @@ async def test_device_override( | |||
|
|
|||
|
|
|||
| async def test_quirks_v2_entity_discovery( | |||
| zha_gateway: Gateway, | |||
| zha_gateway: Gateway, # pylint: disable=unused-argument | |||
There was a problem hiding this comment.
Maybe we should disable unused-argument and redefined-outer-name for any file in tests/?
There was a problem hiding this comment.
on the fence. the redefined-outer-name one saved me a couple times when converting. I am mainly adding the hints to the files when I know they aren't an issue so I don't get distracted by them in vscode. I'll defer to consensus here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.