Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix zigbee groups, updates form zigbee-herdsman #60

Merged
merged 4 commits into from Aug 13, 2020
Merged

Conversation

sanyatuning
Copy link
Collaborator

fix zigbee groups fixes #58
pull updates from zigbee-herdsman

Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Much requested. Thanks

@Adminiuga
Copy link
Contributor

do you need to bump up the version?

@sanyatuning
Copy link
Collaborator Author

do you need to bump up the version?

What do you mean?

@Adminiuga
Copy link
Contributor

I don't think it got successfully published to pypi. Not sure if it was because of the version.
Let me know when it's ready to be updated in homeassistant.

@Hedda
Copy link
Contributor

Hedda commented Aug 10, 2020

@sanyatuning commit/merge, bump version, and release to PyPI?

https://github.com/zigpy/zigpy-cc/releases

https://github.com/zigpy/zigpy-cc/actions

@sanyatuning sanyatuning merged commit 5625ea5 into master Aug 13, 2020
@lociii
Copy link

lociii commented Aug 14, 2020

How's the process of getting the new release integrated in HA core?
Will it still be necessary to repair everything as mentioned in #58 (comment) ?

@Hedda
Copy link
Contributor

Hedda commented Aug 14, 2020

How's the process of getting the new release integrated in HA core?

You can test a new release yourself as per the instructions in -> https://github.com/zigpy/zigpy-cc/blob/master/README.md

For a new release to make in into a new release of upstream HA core for everyone you will have to wait for the devs to do a PR.

@sanyatuning
Copy link
Collaborator Author

@lociii I've added a migration guide to the Readme if you don't want to repair your devices

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Zigbee groups don't switch Tradfri light bulbs
4 participants