Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail with descriptive errors when coordinator is disconnected #203

Merged
merged 1 commit into from Feb 13, 2023

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Feb 10, 2023

AttributeError: 'NoneType' object has no attribute 'request_callback_rsp' makes it sound like there is a library bug.

@puddly puddly force-pushed the puddly/better-disconnect-errors branch from 9f6c2bb to 44064a4 Compare February 10, 2023 21:52
@puddly puddly force-pushed the puddly/better-disconnect-errors branch from 44064a4 to adf6df7 Compare February 11, 2023 04:53
@codecov-commenter
Copy link

Codecov Report

Base: 98.52% // Head: 98.52% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (adf6df7) compared to base (36c5d09).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #203   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          43       43           
  Lines        3799     3803    +4     
=======================================
+ Hits         3743     3747    +4     
  Misses         56       56           
Impacted Files Coverage Δ
zigpy_znp/api.py 96.95% <100.00%> (+0.24%) ⬆️
zigpy_znp/zigbee/application.py 94.80% <100.00%> (-0.24%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@puddly puddly merged commit 9b959dc into zigpy:dev Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants