Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tests broken by zigpy update #246

Merged
merged 4 commits into from Apr 11, 2024

Conversation

TheJulianJES
Copy link
Contributor

@TheJulianJES TheJulianJES commented Apr 11, 2024

This fixes tests that were broken by zigpy 0.60.3 (and later).

For the watchdog change, we can also only move the startup phase (where the watchdog loop gets started) into where the period is patched: 464a9ff, but we might as well patch the period for the entire test (which I did for now). Or is there another preferred way to do it?

cc @puddly

Depending on how GitHub actions work, we might want to merge #245 first to have CI working.
EDIT: Yeah, looks like CI doesn't start at all, so am I fine to merge that Codecov CI first?

@TheJulianJES TheJulianJES marked this pull request as draft April 11, 2024 18:52
@puddly
Copy link
Collaborator

puddly commented Apr 11, 2024

am I fine to merge that Codecov CI first?

Sure, go for it!

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (e3c9fcf) to head (3051bbe).
Report is 1 commits behind head on dev.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #246   +/-   ##
=======================================
  Coverage   98.10%   98.10%           
=======================================
  Files          43       43           
  Lines        3647     3647           
=======================================
  Hits         3578     3578           
  Misses         69       69           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TheJulianJES TheJulianJES marked this pull request as ready for review April 11, 2024 19:04
@puddly puddly merged commit b658bc1 into zigpy:dev Apr 11, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants