Merge pull request #979 from puddly/puddly/listener-exception-logging

Log the entire listener exception traceback when an error occurs
zigpy · Apr 27, 2022 · cab1032 · cab1032
2 parents c519492 + 054a8e4
commit cab1032
Showing 1 changed file with 15 additions and 2 deletions.
diff --git a/zigpy/util.py b/zigpy/util.py
@@ -50,7 +50,12 @@ def listener_event(self, method_name, *args):
                 else:
                     result.append(method(*args))
             except Exception as e:
-                LOGGER.warning("Error calling listener.%s: %s", method_name, e)
+                LOGGER.warning(
+                    "Error calling listener %r with args %r: %r", method, args, e
+                )
+                LOGGER.debug(
+                    "Error calling listener %r with args %r", method, args, exc_info=e
+                )
         return result
 
     async def async_event(self, method_name, *args):
@@ -69,7 +74,15 @@ async def async_event(self, method_name, *args):
         results = []
         for result in await asyncio.gather(*tasks, return_exceptions=True):
             if isinstance(result, Exception):
-                LOGGER.warning("Error calling listener: %s", result)
+                LOGGER.warning(
+                    "Error calling listener %r with args %r: %r", method, args, result
+                )
+                LOGGER.debug(
+                    "Error calling listener %r with args %r",
+                    method,
+                    args,
+                    exc_info=result,
+                )
             else:
                 results.append(result)
         return results