New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional endpoint configuration option #1048
Conversation
Codecov ReportBase: 99.75% // Head: 99.61% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #1048 +/- ##
==========================================
- Coverage 99.75% 99.61% -0.14%
==========================================
Files 46 46
Lines 7202 7216 +14
==========================================
+ Hits 7184 7188 +4
- Misses 18 28 +10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I've added a few comments regarding the config schema parsing.
zigpy/application.py
Outdated
@@ -539,6 +540,9 @@ async def register_endpoints(self): | |||
) | |||
) | |||
|
|||
for add_endpoint in self.config.get(CONF_ADDITIONAL_ENDPOINTS): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once the endpoint dictionary is parsed in zigpy/config/__init__.py
, this code can just become:
for endpoint in self.config[conf.CONF_ADDITIONAL_ENDPOINTS]:
await self.add_endpoint(endpoint)
zigpy/application.py
Outdated
@@ -10,6 +10,7 @@ | |||
import zigpy.appdb | |||
import zigpy.backups | |||
import zigpy.config as conf | |||
from zigpy.config import CONF_ADDITIONAL_ENDPOINTS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zigpy.config
is imported as conf
on the line above, you don't need to add another one.
@pipiche38 could this also be related to zigbeefordomoticz/Domoticz-Zigbee#1145 or is that issue only on the coordinator side? @prairiesnpr, for reference, exactly which Zigbee USB radio adapter are you using to test and exactly which firmware does it have? |
My understanding is that it should be done at the radio lib level ( ZNP, deConz or EZSP) because every coordinator as it is way to handle it. |
It's one of Tube's Poe models. cc2652p2, firmware 20220219. Will also need zigpy/zigpy-znp#175 for this to work. |
Address Requested Changes
This PR adds a configuration option to allow adding additional endpoints.
This is required for xbee end devices as they require 0xE6 and 0xE8 endpoints and by default zigpy ignores those.
Example configuration.