Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported attributes when they become supported #1091

Merged
merged 9 commits into from
Nov 12, 2022

Conversation

dmulcahey
Copy link
Collaborator

@dmulcahey dmulcahey commented Nov 5, 2022

This PR removes unsupported attributes if they become supported in the future. This can be from a firmware update or a quirk update etc.

@puddly let me know if you want to do this differently. I think I covered everything. I have an outstanding note in one of the tests for something that is a bit confusing.

@codecov-commenter
Copy link

codecov-commenter commented Nov 5, 2022

Codecov Report

Base: 99.63% // Head: 99.63% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (179b82a) compared to base (8a2c754).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev    #1091   +/-   ##
=======================================
  Coverage   99.63%   99.63%           
=======================================
  Files          46       46           
  Lines        7590     7675   +85     
=======================================
+ Hits         7562     7647   +85     
  Misses         28       28           
Impacted Files Coverage Δ
zigpy/appdb.py 99.36% <100.00%> (+<0.01%) ⬆️
zigpy/zcl/__init__.py 99.76% <100.00%> (+0.01%) ⬆️
zigpy/ota/image.py 100.00% <0.00%> (ø)
zigpy/ota/__init__.py 100.00% <0.00%> (ø)
zigpy/config/__init__.py 100.00% <0.00%> (ø)
zigpy/config/defaults.py 100.00% <0.00%> (ø)
zigpy/ota/provider.py 99.78% <0.00%> (+0.02%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

tests/test_appdb.py Outdated Show resolved Hide resolved
@dmulcahey dmulcahey marked this pull request as ready for review November 5, 2022 19:32
@dmulcahey dmulcahey requested a review from puddly November 5, 2022 19:33
zigpy/zcl/__init__.py Outdated Show resolved Hide resolved
@puddly puddly force-pushed the dm/purge-unsupported-attributes branch from 179b82a to deff5e2 Compare November 12, 2022 00:48
@puddly puddly merged commit 2d24c01 into zigpy:dev Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants