-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unsupported attributes when they become supported #1091
Conversation
Codecov ReportBase: 99.63% // Head: 99.63% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev #1091 +/- ##
=======================================
Coverage 99.63% 99.63%
=======================================
Files 46 46
Lines 7590 7675 +85
=======================================
+ Hits 7562 7647 +85
Misses 28 28
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
179b82a
to
deff5e2
Compare
This PR removes unsupported attributes if they become supported in the future. This can be from a firmware update or a quirk update etc.
@puddly let me know if you want to do this differently. I think I covered everything. I have an outstanding note in one of the tests for something that is a bit confusing.