Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify some structs by using t.StructField(requires=...) instead of custom serialize/deserialize methods #456

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Simplify some structs by using t.StructField(requires=...) instead of custom serialize/deserialize methods #456

merged 2 commits into from
Aug 12, 2020

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Aug 12, 2020

Use t.StructField(requires=...) to replace a couple of custom serialization/deserialization functions. Affected classes are zigpy.ota.image.OTAImageHeader and zigpy.zdo.types.NwkUpdate.

@coveralls
Copy link

coveralls commented Aug 12, 2020 •
edited

Coverage Status

Coverage remained the same at 100.0% when pulling fd67798 on puddly:improvement/struct-simplification into a39e6fd on zigpy:dev.

@Adminiuga Adminiuga merged commit 0d9a149 into zigpy:dev Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Adminiuga Adminiuga Adminiuga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@puddly @coveralls @Adminiuga