Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mgmt_Bind_req and Mgmt_Bind_rsp ZDO commands. #729

Merged
merged 3 commits into from
May 12, 2021
Merged

Conversation

JeremieLeGrand
Copy link
Contributor

These commands are usefull to get remote device binding table entries.

…usefull to get remote device binding table entries.
@coveralls
Copy link

coveralls commented May 7, 2021

Coverage Status

Coverage increased (+0.0002%) to 99.846% when pulling 9cc5fb9 on Legrandgroup:dev into fe9af15 on zigpy:dev.

@codecov-commenter
Copy link

Codecov Report

Merging #729 (236e104) into dev (fe9af15) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #729   +/-   ##
=======================================
  Coverage   99.84%   99.84%           
=======================================
  Files          43       43           
  Lines        5837     5844    +7     
=======================================
+ Hits         5828     5835    +7     
  Misses          9        9           
Impacted Files Coverage Δ
zigpy/zdo/types.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe9af15...236e104. Read the comment docs.

("BindingTableEntries", t.uint8_t),
("StartIndex", t.uint8_t),
("BindingTableListCount", t.uint8_t),
("BindingTableList", t.List[Binding]),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Since the size of the table precedes its length, could you merge:

        ("BindingTableListCount", t.uint8_t),
        ("BindingTableList", t.List[Binding]),

Into:

        ("BindingTableList", t.LVList[Binding]),

@puddly puddly merged commit 103ac00 into zigpy:dev May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants