Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Ledvance OTA by accounting for new JSON version keys #801

Merged
merged 2 commits into from Sep 2, 2021

Conversation

puddly
Copy link
Collaborator

@puddly puddly commented Sep 2, 2021

Fixes #800

Thanks @Nealtron!

Copy link
Collaborator

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That was quick :)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 99.818% when pulling 58c3062 on puddly:puddly/ledvance-provider-fix into 22d1c6c on zigpy:dev.

@Adminiuga Adminiuga merged commit c60b6b9 into zigpy:dev Sep 2, 2021
@Adminiuga Adminiuga added the bug Something isn't working label Sep 2, 2021
@Nealtron
Copy link

Nealtron commented Sep 2, 2021

It's worth noting that the documentation for the API identifies a method to download the "latest".

https://api.update.ledvance.com/v1/zigbee/firmwares/download/{company}/{product}/latest
vs
https://api.update.ledvance.com/v1/zigbee/firmwares/download[?Company][&Product][&Version]

Documentation for current method:
https://portal.update.ledvance.com/docs/services/firmware-rest-api/operations/5d8e482edb442c3151c64fae?

Documentation for "latest" method:
https://portal.update.ledvance.com/docs/services/firmware-rest-api/operations/5d8e482e89d78b3d6bf67e69?

Adminiuga pushed a commit that referenced this pull request Sep 3, 2021
* Fix Ledvance OTA by accounting for new JSON version keys
Fixes #800

* Clarify `LedvanceImage` arguments
Adminiuga pushed a commit that referenced this pull request Sep 3, 2021
* Fix Ledvance OTA by accounting for new JSON version keys
Fixes #800

* Clarify `LedvanceImage` arguments
puddly added a commit that referenced this pull request Jul 6, 2023
* 0.20.0 version bump.

* 0.20.1 version bump

* 0.20.2 version bump.

* 0.20.3 version bump

* 0.20.4 version bump.

* 0.21.0 Version bump

* 0.22.0 version bump

* 0.22.1 version bump.

* 0.22.2 version bump.

* 0.23.0 version bump

* 0.23.1 version bump.

* 0.23.2 version bump

* 0.24.0 version bump

* 0.24.1 version bump

* 0.24.2 version bump

* 0.24.3 version bump

* 0.25.0 Version bump

* 0.26.0 version bump

* 0.27.0 Version bump

* 0.27.1 version bump

* Bump up version to 0.28.0

* 0.28.1 version bump

* 0.28.2 version bump

* 0.29.0 Version bump

* 0.30.0 version bump

* 0.30.1 version bump

* 0.31.0 Version bump

* 0.32.0 version bump

* 0.33.0 version bump

* 0.34.0 Version bump

* 0.35.0 version bump

* 0.35.1 Version bump

* 0.35.2 Version bump

* 0.36.0 Version bump

* 0.36.1 Version bump

* 0.36.2 Version bump

* 0.37.0 version bump

* 0.37.1 version bump

* Fix Ledvance OTA by accounting for new JSON version keys (#801)

* Fix Ledvance OTA by accounting for new JSON version keys
Fixes #800

* Clarify `LedvanceImage` arguments

* 0.37.2 version bump

* 0.38.0 Version bump

* 0.39.0 version bump

* 0.40.0 Version bump

* 0.41.0 Version bump.

* 0.42.0 Version bump

* 0.43.0 Version bump.

* #873 Add write_attributes_raw method (#887)

* Add write_attributes_raw method
Enables writing attributes that are not predefined.
Similar to read_attributes_raw

* Alphabetical order for radios

* Better argument name for write_attributes_raw

* Need await on write_attributes_raw call

* Renamed other occurences of 'args'

* Try multiple mock patch to catch uppermost exception

* Adjusted test to detect exception, also test other method

* Removed dual mock test

* Renamed args to attrs in write_attributes

* 0.44.0 Version bump

* Bump patch version to 0.44.1

* Bump patch version to 0.44.1

* 0.44.2 Release

* 0.45.0 version bump

* 0.45.1 version bump

* 0.46.0 Release

* Bump version to 0.47.0

* Bump version to 0.47.1

* 0.47.2 release

* 0.47.3 version bump

* 0.48.0 version bump

* 0.49.0 version bump

* 0.49.1 version bump

* 0.50.0 version bump

* Bump version to 0.50.1

* 0.50.2 version bump

* Bump version to 0.50.3

* 0.51.0 version bump

* 0.51.1 version bump

* 0.51.2 version bump

* 0.51.3 version bump

* 0.51.4 version bump

* 0.51.5 version bump

* 0.51.6 version bump

* 0.52.0 version bump

* 0.52.1 version bump

* 0.52.2 version bump

* 0.52.3 version bump

* 0.53.0 version bump

* 0.53.1 version bump

* 0.53.2 version bump

* Bump version to 0.53.3

* 0.54.0 version bump

* 0.54.1 version bump

* 0.55.0 version bump

* 0.56.0 version bump

* 0.56.1 version bump

---------

Co-authored-by: Alexei Chetroi <lexoid@gmail.com>
Co-authored-by: Alexei Chetroi <Alexei.Chetroi@outlook.com>
Co-authored-by: MDW <mdeweerd@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OTA Update for LEDVANCE fails with "No OTA image is available"
4 participants