Persist Device.last_seen in the database
#971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unit tests need to be fixed for 3.7, there seems to be some issue with |
puddly
force-pushed
the
puddly/persist-last_seen
branch
from
32bd279
to
08fecee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
last_seenwill now be persisted in the database and loaded on startup.I've also added a runtime check to
_migrate_tablesto ensure that all "old" tables are explicitly specified in the migration. This will protect against migrations that accidentally leave out a new table introduced in an earlier migration (like I almost did when making this PR 馃槂).