Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested struct init fields completion #1116

Closed
wants to merge 1 commit into from

Conversation

llogick
Copy link
Member

@llogick llogick commented Apr 5, 2023

Attempt at making nested struct init fields completion work

Needs testing.. more so that it doesn't break existing stuff.

Examples (ignore the obvious field types mismatch, didn't need to be correct for this autocomplete example):
nested_struct_init_example1
nested_struct_init_example2
nested_struct_init_example3

@SuperAuguste SuperAuguste added the pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!) label Apr 5, 2023
@leecannon
Copy link
Member

Looks like github got confused with this one, I merged this PR in 7978485 but the page froze and after refresh the PR is still open and is complaining about conflicts before merging (and it looks like it is conflicting with itself).

This PR has definitely been merged into master (735f884) so i'm going to close this PR.

@leecannon leecannon closed this Apr 13, 2023
@llogick llogick deleted the nested-struct-init branch April 13, 2023 12:54
llogick pushed a commit to llogick/zls that referenced this pull request Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:fuzz Attach to a PR to start fuzzing / continually fuzz (please do this before merging!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants