-
-
Notifications
You must be signed in to change notification settings - Fork 268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function argument removed #1852
Function argument removed #1852
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1852 +/- ##
=======================================
Coverage 78.49% 78.49%
=======================================
Files 34 34
Lines 10650 10650
=======================================
Hits 8360 8360
Misses 2290 2290 ☔ View full report in Codecov by Sentry. |
Just noting that this change requires ziglang/zig@c4587dc at minimum. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires zig 0.12.0-dev.3631+c4587dc9f
You could update min_zig_string in build.zig or Techatrix will when updating the nix flake.
Flake lock file updates: • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/bb2b73df7bcfbd2dd55ff39b944d70547d53c267' (2024-03-28) → 'github:NixOS/nixpkgs/d6b3ddd253c578a7ab98f8011e59990f21dc3932' (2024-04-10) • Updated input 'zig-overlay': 'github:mitchellh/zig-overlay/b01e0b81d1fa489e54362ea0a74f182eaa9a35bb' (2024-03-28) → 'github:mitchellh/zig-overlay/9687044a467176bea9e3f0a972143bcbad5dae90' (2024-04-11)
The last line should be the commit title of `0.12.0-dev.3631+c4587dc9f`
This function no longer contains any arguments.
https://github.com/ziglang/zig/pull/19598/files#diff-ab7384310a623b1845d2013b68374070ab590b1cc82d786e188fadc3f70ccda5L805