Remove duplicated deinit defer for GPA #504
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not sure there's a valuable test here that wouldn't make this PR an entirety of testing main.zig to prove there's not double de-inits on exit, which would require moving a bunch of stuff out of main. As such, I just tested this with a generated ZLS config and running ZLS for a bit. Seems like some sort of linter in the language server could deal with this issue if it can't be detected at compile time. |
|
Oops, my bad, I think I caused this problem while rebasing; thanks for the fix! Just gonna wait for the CI to pass and then I'll merge. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes duplicated deinit on the allocator. Fixes #503.