Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

References improvements #653

Merged
merged 8 commits into from
Sep 16, 2022
Merged

Conversation

Techatrix
Copy link
Member

@Techatrix Techatrix commented Sep 14, 2022

This PR merges the code responsible for textDocument/rename, textDocument/references and textDocument/documentHighlight because they are very similar. And references.zig receives a large refactor. fixes #654

These features are still very buggy and i will address that in later PRs.

@llogick
Copy link
Member

llogick commented Sep 14, 2022

i'm sure you're ahead of me, so i'll ask here

wouldn't

        .anyframe_type,
        .@"defer",
        .@"errdefer",
        .@"comptime",
        .@"nosuspend",
        => {
            try symbolReferencesInternal(arena, locations, store, .{ .node = datas[node].lhs, .handle = handle }, decl, encoding);
        },

address #654 ?

@Techatrix Techatrix linked an issue Sep 15, 2022 that may be closed by this pull request
@Techatrix
Copy link
Member Author

This is now fixed in my refactor, but many bugs remain...

Copy link
Member

@SuperAuguste SuperAuguste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏👏👏

@Techatrix Techatrix merged commit b76710e into zigtools:master Sep 16, 2022
@Techatrix Techatrix deleted the references-improvements branch September 18, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename does not track errdefers
3 participants