Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add target to Env struct #656

Merged
merged 1 commit into from
Sep 18, 2022
Merged

Add target to Env struct #656

merged 1 commit into from
Sep 18, 2022

Conversation

jcmoyer
Copy link
Contributor

@jcmoyer jcmoyer commented Sep 15, 2022

Fixes an issue where zls couldn't parse the output from zig env causing it to repeatedly print

debug: (store ): Cannot resolve std library import, path is null.

and fail to autocomplete.

See: ziglang/zig#11741

@SuperAuguste
Copy link
Member

Website CI is broken; I'll merge this when it's fixed :)

Copy link
Member

@leecannon leecannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will need to be target: ?[]const u8 = null, to work with older zig versions, including CI atm.

@nektro
Copy link
Contributor

nektro commented Sep 17, 2022

set ignore_unknown_fields = true in our std.json.ParseOptions instead

@jcmoyer
Copy link
Contributor Author

jcmoyer commented Sep 18, 2022

I'm not sure which behavior is more preferrable (add target field or use ignore_unknown_fields). I only became aware of the zig env change explicitly because ignore_unknown_fields wasn't being used.

@leecannon leecannon merged commit b3078c3 into zigtools:master Sep 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants