handle OptionsStep
in build_runner
#686
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows generated files from
OptionsStep
to be resolved.This is dependant on ziglang/zig#13003 I will leave it as a draft until it is merged.
I'm not 100% happy with this due to:
OptionsStep
s that have no dependencies.Thankfully this is the most common situation, I don't think i've ever seen an
OptionsStep
have any dependencies.build_options
, this could easily result in multiple packages with the same name pointing to different files.As before this is an uncommon issue to hit as multiple
OptionsStep
s is rare.This is one more reason the TODO in
build_runner.zig
would be nice to fix.zls/src/special/build_runner.zig
Lines 93 to 95 in 8cf93fc
Before:
After: