Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API for retrieving theme in monaco-editor version 0.21.2 #16

Closed
wants to merge 2 commits into from

Conversation

miketromba
Copy link

The new API is: editor._themeService._theme instead of editor._themeService.getTheme()

The new API is: editor._themeService._theme instead of editor._themeService.getTheme()
@zikaari
Copy link
Owner

zikaari commented Jan 12, 2021

Can you please document this breaking change in README? i.e inform people that the latest version of this package requires monaco-editor version <x.x.x> or up (the minimum version that brought this change) and if they wish to use it with version <x.x.x> or below they can use an older version 2.2.2 of this library.

Your contribution is truly appreciated.

@miketromba
Copy link
Author

miketromba commented Jan 13, 2021

Hey Neek, I'm not very familiar with working with PR's, but I'll assume I can just push another commit to this PR without creating a new one... going to give that a try. ...Looks like it worked

One question: should I also worry about incrementing any version numbers in the package.json? I'm not very familiar with NPM publishing either haha.

@tpisto
Copy link
Contributor

tpisto commented Sep 12, 2022

Please can this be merged... all the recent Monaco versions are not working. I can confirm that his fixes the issue 👍🏻

@zikaari
Copy link
Owner

zikaari commented Sep 14, 2022

I'll merge this later today

@zikaari
Copy link
Owner

zikaari commented Sep 17, 2022

My apologies for the slack folks, been quite busy at work this week.

I'm gonna need someone to resolve the conflicts though, it's been 4 years since I've used this library (or monaco) personally so don't know which changes I need to keep and which to discard.

@tpisto
Copy link
Contributor

tpisto commented Sep 17, 2022

I created new pull request that has latest version as base

@zikaari
Copy link
Owner

zikaari commented Sep 20, 2022

Merged #23 instead

@zikaari zikaari closed this Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants