Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move tslint to devDependencies list #20

Closed
lukeed opened this issue Jun 13, 2020 · 6 comments · Fixed by #22
Closed

Move tslint to devDependencies list #20

lukeed opened this issue Jun 13, 2020 · 6 comments · Fixed by #22

Comments

@lukeed
Copy link
Contributor

lukeed commented Jun 13, 2020

Hey there,

I'm not very familiar with this module (sorry!) but I discovered that it's pulling in tslint as a dependency, which makes it significantly harder/impossible to use in modern browsers with ESM.

And in Node.js projects, it forces tslint (and all that comes with it) to be installed ... even though it appears to do nothing.

Thanks!

lukeed added a commit to lukeed/onigasm that referenced this issue Jun 13, 2020
@zikaari
Copy link
Owner

zikaari commented Jun 13, 2020

Please see if this fixes the bundling issue - shikijs/shiki#22 (comment)

Will push the patch, over the weekend sometime. cheers.

@lukeed
Copy link
Contributor Author

lukeed commented Jun 19, 2020

I know it can be bypassed. It just shouldn't be there.

@octref
Copy link

octref commented Sep 17, 2020

Hey @NeekSandhu, do you mind merging #22 and make this happen?

I'm in the process of reducing shiki's size, and tslint dependency is 3MB.

@zikaari
Copy link
Owner

zikaari commented Sep 21, 2020

@octref @lukeed apologies for the slack guys. will get this sorted tonight 👍

zikaari pushed a commit that referenced this issue Sep 22, 2020
@zikaari
Copy link
Owner

zikaari commented Sep 22, 2020

2.2.5 is now live, can you please double-check if everything's nominal?

@octref
Copy link

octref commented Sep 22, 2020

Yes everything's normal, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants