Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase length of ip address fields for IPv6 support #2893

Closed
Guite opened this issue Jun 3, 2016 · 1 comment
Closed

Increase length of ip address fields for IPv6 support #2893

Guite opened this issue Jun 3, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@Guite
Copy link
Member

Guite commented Jun 3, 2016

If the web server is configured as dual stack allowing both IPv4 and IPv6 requests it may happen that the ip address gathered from $_SERVER['REMOTE_ADDR'] is a IPv6 address. This can lead to problems if corresponding database fields are too short. Ip address fields should therefore be enlarged to at least 39 chars.

SecurityCenter is fine (has 40 chars already):
https://github.com/zikula/core/blob/1.4/src/system/SecurityCenterModule/Entity/IntrusionEntity.php#L84

PageLock needs a change:
https://github.com/zikula/core/blob/1.4/src/system/PageLockModule/Entity/PageLockEntity.php#L84

Users needs a change for sessions:
https://github.com/zikula/core/blob/1.4/src/system/UsersModule/Entity/UserSessionEntity.php#L40

I don't know if there are other additional fields in the core, this needs to be checked, too.

@Guite Guite added the Feature label Jun 3, 2016
@Guite Guite added this to the 1.4.3 milestone Jun 3, 2016
@craigh craigh modified the milestones: 1.4.3, 1.4.4 Jul 11, 2016
@Guite Guite modified the milestones: 1.4.3, 1.4.4 Aug 19, 2016
@Guite Guite self-assigned this Aug 19, 2016
@Guite Guite added the ZCS label Aug 19, 2016
@Guite
Copy link
Member Author

Guite commented Aug 19, 2016

Done in #2997

@Guite Guite closed this as completed Aug 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants