-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update Hooks to Symfony 5 #4593
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This includes temporary example files in `/App` and modifies the following files in order to achieve those: composer.json config/services.yaml config/routes/annotations.yaml These files should be changed back when testing is complete.
…nterface on each event, autoconfigure each event. Add beginning of new connections controller
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
…dles. When deprecated code is fully removed, the dependencies on Zikula bundles will be gone
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions:
-
How is the connection entity's table going to be created if the hook bundle will be used in a non-Zikula environment? Flex recipe? Auto detection? (of course this is outside of this PR).
-
Do you have considered a place in UI where the user can see the summary/information about a hook (like described in [HookBundle] Helppage for each Hook #4398)? Didn't find it.
Otherwise go for it 👍 👍 🍰 🥇
There is a new schema:create command in this PR that could be used, but ultimately, that would be the problem of the developer implementing it..
There is a list under the UI with all the HookEvents and HookEventListeners. |
This includes temporary example files in
/App
and modifies the following files in order to achieve those:These files should be changed back when testing is complete.
These files should be removed:
Todos
Tests - for HookLocator, Connection?