Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include default query params in href #138

Merged
merged 1 commit into from
Dec 9, 2023

Conversation

garronej
Copy link
Contributor

@garronej garronej commented Dec 8, 2023

Implements #137

@bradenhs
Copy link
Contributor

bradenhs commented Dec 8, 2023

The code looks great! I tested it out and everything works as expected! Thanks for the contribution!

Once CI passes I'll merge and release a new Type Route version today.

@bradenhs
Copy link
Contributor

bradenhs commented Dec 9, 2023

Huh... CI is still stuck. I might need to update the github action. I ran tests locally though and everything looks good. I'll merge this now and get CI fixed then deploy (maybe early next week).

@bradenhs bradenhs merged commit e9b6b7b into zilch:main Dec 9, 2023
0 of 3 checks passed
@garronej garronej deleted the impl_137 branch December 11, 2023 16:25
@garronej
Copy link
Contributor Author

Thank you for reviewing and merging!

The code looks great! I tested it out and everything works as expected! Thanks for the contribution!

No problem, the code is very well organized so it went very somothly!

Huh... CI is still stuck. I might need to update the github action.

I saw you're using tsdx... I'm quite reseved about this project. In particular because it bundles all the code into a single file which it not how npm module should be distributed.

Anyway, I'm very happy this feature is now part of type-route.

And by the way, I don't know if I told you but I recomend type-route in the documentation for building french public services websites with React:

https://react-dsfr.codegouv.studio/routing

Note that I recomend to use type-route instead of react-router.

As a result some important project are being build with type route such as this one:

https://www.linkedin.com/feed/update/urn:li:activity:7131185504712028160?updateEntityUrn=urn%3Ali%3Afs_feedUpdate%3A%28V2%2Curn%3Ali%3Aactivity%3A7131185504712028160%29

@bradenhs
Copy link
Contributor

So happy to hear about different places where Type Route is being used and appreciated! Thank you for sharing. On the subject of tsdx I'd be happy to explore migrating to a different solution sometime, but it won't be a priority of mine in the near future. I've also been less keen about tsdx lately and wouldn't start a new project using it.

@garronej
Copy link
Contributor Author

garronej commented Dec 11, 2023

Of course, I'm not sugesting you migrate, it wouldn't be worth the effort. I was just mentioning it casually.
If you want to explore other options you might want to chechout my starter https://github.com/garronej/ts-ci.
I had to create one for my own modules.

@bradenhs
Copy link
Contributor

Nice! I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants