Merge pull request #144 from syguer/add_finder

Implement .find_by!

CHANGELOG

@@ -1,3 +1,6 @@
+2017-03-24 (v1.5.0)
+  - add support for `.find_by!`(@syguer)
+
 2015-09-13 (v1.4.1)
   - fix bug where `#attributes` didn't contain default values #107
   - add support for `.find_by` and `#_read_attribute`. Thanks, @andrewfader!

README.md

@@ -141,15 +141,17 @@ If you prefer to store your data in YAML, see below.
 
 ActiveHash gives you ActiveRecord-esque methods like:
 ```ruby
-Country.all             # => returns all Country objects
-Country.count           # => returns the length of the .data array
-Country.first           # => returns the first country object
-Country.last            # => returns the last country object
-Country.find 1          # => returns the first country object with that id
-Country.find [1,2]      # => returns all Country objects with ids in the array
-Country.find :all       # => same as .all
-Country.find :all, args # => the second argument is totally ignored, but allows it to play nicely with AR
-Country.find_by_id 1    # => find the first object that matches the id
+Country.all                  # => returns all Country objects
+Country.count                # => returns the length of the .data array
+Country.first                # => returns the first country object
+Country.last                 # => returns the last country object
+Country.find 1               # => returns the first country object with that id
+Country.find [1,2]           # => returns all Country objects with ids in the array
+Country.find :all            # => same as .all
+Country.find :all, args      # => the second argument is totally ignored, but allows it to play nicely with AR
+Country.find_by_id 1         # => find the first object that matches the id
+Country.find_by(name: 'US')  # => returns the first country object with specified argument
+Country.find_by!(name: 'US') # => same as find_by, but raise exception when not found
 ```
 It also gives you a few dynamic finder methods.  For example, if you defined :name as a field, you'd get:
 ```ruby

active_hash.gemspec

@@ -28,6 +28,7 @@ Gem::Specification.new do |s|
     "Matthew O'Riordan",
     "Brett Richardson",
     "Rachel Heaton",
+    "Keisuke Izumiya"
   ]
   s.email = %q{jeff@zilkey.com}
   s.summary = %q{An ActiveRecord-like model that uses a hash or file as a datasource}

lib/active_hash/base.rb

@@ -172,6 +172,10 @@ def find_by(options)
         where(options).first
       end
 
+      def find_by!(options)
+        find_by(options) || (raise RecordNotFound.new("Couldn't find #{name}"))
+      end
+
       def match_options?(record, options)
         options.all? do |col, match|
           if match.kind_of?(Array)

lib/active_hash/version.rb

@@ -1,5 +1,5 @@
 module ActiveHash
   module Gem
-    VERSION = "1.4.1"
+    VERSION = "1.5.0"
   end
 end

spec/active_hash/base_spec.rb

@@ -338,6 +338,28 @@ class Region < ActiveHash::Base
     end
   end
 
+  describe ".find_by!" do
+    before do
+      Country.field :name
+      Country.field :language
+      Country.data = [
+        {:id => 1, :name => "US", :language => 'English'}
+      ]
+    end
+
+    subject { Country.find_by!(name: word) }
+
+    context 'when data exists' do
+      let(:word) { 'US' }
+      it { expect(subject.id).to eq 1 }
+    end
+
+    context 'when data not found' do
+      let(:word) { 'UK' }
+      it { expect{ subject }.to raise_error ActiveHash::RecordNotFound }
+    end
+  end
+
   describe ".count" do
     before do
       Country.data = [