Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculation error in client.bills()['tx'] #22

Closed
Belvaaaan opened this issue Aug 15, 2022 · 0 comments
Closed

Calculation error in client.bills()['tx'] #22

Belvaaaan opened this issue Aug 15, 2022 · 0 comments
Assignees
@zillionare
Labels
bug Something isn't working

Comments

@Belvaaaan
Copy link

Describe the bug

In traderclient, 'pprofit' of client.bills()['tx'] is wrong.

To Reproduce

Steps to reproduce the behavior:

  1. finishing backtesting
  2. running client.bills()['tx']

Expected behavior

Recorrect this calculation error.

Screenshots

{'sec': '600600.XSHG',
'entry_time': '2022-07-19T15:00:00',
'exit_time': '2022-08-01T10:00:00',
'entry_price': 95.12607186174652,
'exit_price': 106.390005664908,
'shares': 23.1,
'fee': 0.25,
'profit': 259.9468708530302,
'pprofit': 11.253111292338968,
'window': 10}]

Version

backtest version:
backtesting==0.4.8
@Belvaaaan Belvaaaan added bug Something isn't working help wanted Extra attention is needed labels Aug 15, 2022
@zillionare zillionare self-assigned this Aug 27, 2022
@zillionare zillionare removed the help wanted Extra attention is needed label Aug 27, 2022
zillionare pushed a commit that referenced this issue Aug 27, 2022
@aaron-yang-biz
🐞 fix: calculation error in client.bills
d116385 
#22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zillionare zillionare

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zillionare @Belvaaaan