Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve coverage testing #194

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Improve coverage testing #194

merged 1 commit into from
Apr 13, 2023

Conversation

SimFG
Copy link
Collaborator

@SimFG SimFG commented Apr 13, 2023

No description provided.

@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: SimFG

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 13, 2023

Codecov Report

Merging #194 (2695016) into dev (1148f55) will increase coverage by 11.00%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              dev     #194       +/-   ##
===========================================
+ Coverage   80.79%   91.80%   +11.00%     
===========================================
  Files          42       42               
  Lines        1234     1232        -2     
===========================================
+ Hits          997     1131      +134     
+ Misses        237      101      -136     
Impacted Files Coverage Δ
gptcache/similarity_evaluation/__init__.py 100.00% <ø> (+16.66%) ⬆️
gptcache/utils/__init__.py 86.20% <ø> (+6.89%) ⬆️
gptcache/utils/error.py 90.90% <ø> (+5.19%) ⬆️
gptcache/embedding/__init__.py 100.00% <100.00%> (+15.00%) ⬆️
gptcache/embedding/huggingface.py 85.71% <100.00%> (ø)
gptcache/embedding/sbert.py 100.00% <100.00%> (+4.54%) ⬆️
gptcache/manager/vector_data/chroma.py 84.84% <100.00%> (+0.47%) ⬆️

... and 8 files with indirect coverage changes

Signed-off-by: SimFG <bang.fu@zilliz.com>
@mergify mergify bot added the ci-passed label Apr 13, 2023
@SimFG SimFG merged commit f4cde99 into zilliztech:dev Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants