Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logger for gptcache #216

Merged
merged 1 commit into from
Apr 17, 2023
Merged

Add logger for gptcache #216

merged 1 commit into from
Apr 17, 2023

Conversation

shiyu22
Copy link
Contributor

@shiyu22 shiyu22 commented Apr 17, 2023

No description provided.

Signed-off-by: shiyu22 <shiyu.chen@zilliz.com>
@sre-ci-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: shiyu22
To complete the pull request process, please assign simfg after the PR has been reviewed.
You can assign the PR to them by writing /assign @simfg in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Apr 17, 2023

Codecov Report

Merging #216 (d36ceb7) into dev (112aae9) will increase coverage by 0.09%.
The diff coverage is 66.66%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #216      +/-   ##
==========================================
+ Coverage   92.55%   92.64%   +0.09%     
==========================================
  Files          47       48       +1     
  Lines        1504     1509       +5     
==========================================
+ Hits         1392     1398       +6     
+ Misses        112      111       -1     
Impacted Files Coverage Δ
gptcache/__init__.py 95.40% <50.00%> (+0.05%) ⬆️
gptcache/manager/data_manager.py 88.70% <50.00%> (+0.09%) ⬆️
gptcache/manager/object_data/local_storage.py 83.87% <50.00%> (-0.51%) ⬇️
gptcache/manager/object_data/s3_storage.py 84.84% <50.00%> (-0.45%) ⬇️
gptcache/manager/vector_data/milvus.py 86.84% <60.00%> (+1.31%) ⬆️
gptcache/utils/dependency_control.py 100.00% <100.00%> (ø)
gptcache/utils/log.py 100.00% <100.00%> (ø)

@SimFG SimFG merged commit f7587d2 into zilliztech:dev Apr 17, 2023
6 of 7 checks passed
SimFG pushed a commit that referenced this pull request Apr 17, 2023
Signed-off-by: shiyu22 <shiyu.chen@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants